Refactoring with Codemods to Automate API Adjustments

Clear a Stale Function Toggle

Let’s begin with a easy but sensible instance to reveal the
energy of codemods. Think about you’re utilizing a function
toggle in your
codebase to regulate the discharge of unfinished or experimental options.
As soon as the function is dwell in manufacturing and dealing as anticipated, the following
logical step is to wash up the toggle and any associated logic.

As an illustration, contemplate the next code:

const knowledge = featureToggle('feature-new-product-list') ? { identify: 'Product' } : undefined;

As soon as the function is absolutely launched and not wants a toggle, this
may be simplified to:

const knowledge = { identify: 'Product' };

The duty includes discovering all cases of featureToggle within the
codebase, checking whether or not the toggle refers to
feature-new-product-list, and eradicating the conditional logic surrounding
it. On the identical time, different function toggles (like
feature-search-result-refinement, which can nonetheless be in improvement)
ought to stay untouched. The codemod must perceive the construction
of the code to use adjustments selectively.

Understanding the AST

Earlier than we dive into writing the codemod, let’s break down how this
particular code snippet appears in an AST. You should use instruments like AST
Explorer to visualise how supply code and AST
are mapped. It’s useful to know the node sorts you are interacting
with earlier than making use of any adjustments.

The picture under reveals the syntax tree when it comes to ECMAScript syntax. It
comprises nodes like Identifier (for variables), StringLiteral (for the
toggle identify), and extra summary nodes like CallExpression and
ConditionalExpression.

Determine 2: The Summary Syntax Tree illustration of the function toggle test

On this AST illustration, the variable knowledge is assigned utilizing a
ConditionalExpression. The take a look at a part of the expression calls
featureToggle('feature-new-product-list'). If the take a look at returns true,
the consequent department assigns { identify: 'Product' } to knowledge. If
false, the alternate department assigns undefined.

For a job with clear enter and output, I desire writing exams first,
then implementing the codemod. I begin by defining a unfavorable case to
guarantee we don’t unintentionally change issues we need to depart untouched,
adopted by an actual case that performs the precise conversion. I start with
a easy state of affairs, implement it, then add a variation (like checking if
featureToggle known as inside an if assertion), implement that case, and
guarantee all exams go.

This strategy aligns nicely with Take a look at-Pushed Improvement (TDD), even
when you don’t follow TDD frequently. Realizing precisely what the
transformation’s inputs and outputs are earlier than coding improves security and
effectivity, particularly when tweaking codemods.

With jscodeshift, you’ll be able to write exams to confirm how the codemod
behaves:

const rework = require("../remove-feature-new-product-list");

defineInlineTest(
  rework,
  {},
  `
  const knowledge = featureToggle('feature-new-product-list') ? { identify: 'Product' } : undefined;
  `,
  `
  const knowledge = { identify: 'Product' };
  `,
  "delete the toggle feature-new-product-list in conditional operator"
);

The defineInlineTest operate from jscodeshift permits you to outline
the enter, anticipated output, and a string describing the take a look at’s intent.
Now, operating the take a look at with a traditional jest command will fail as a result of the
codemod isn’t written but.

The corresponding unfavorable case would make sure the code stays unchanged
for different function toggles:

defineInlineTest(
  rework,
  {},
  `
  const knowledge = featureToggle('feature-search-result-refinement') ? { identify: 'Product' } : undefined;
  `,
  `
  const knowledge = featureToggle('feature-search-result-refinement') ? { identify: 'Product' } : undefined;
  `,
  "don't change different function toggles"
);

Writing the Codemod

Let’s begin by defining a easy rework operate. Create a file
known as rework.js with the next code construction:

module.exports = operate(fileInfo, api, choices) {
  const j = api.jscodeshift;
  const root = j(fileInfo.supply);

  // manipulate the tree nodes right here

  return root.toSource();
};

This operate reads the file right into a tree and makes use of jscodeshift’s API to
question, modify, and replace the nodes. Lastly, it converts the AST again to
supply code with .toSource().

Now we will begin implementing the rework steps:

1. Discover all cases of featureToggle.
2. Confirm that the argument handed is 'feature-new-product-list'.
3. Change the whole conditional expression with the consequent half,
   successfully eradicating the toggle.

Right here’s how we obtain this utilizing jscodeshift:

module.exports = operate (fileInfo, api, choices) {
  const j = api.jscodeshift;
  const root = j(fileInfo.supply);

  // Discover ConditionalExpression the place the take a look at is featureToggle('feature-new-product-list')
  root
    .discover(j.ConditionalExpression, {
      take a look at: {
        callee: { identify: "featureToggle" },
        arguments: [{ value: "feature-new-product-list" }],
      },
    })
    .forEach((path) => {
      // Change the ConditionalExpression with the 'consequent'
      j(path).replaceWith(path.node.consequent);
    });

  return root.toSource();
};

The codemod above:

• Finds ConditionalExpression nodes the place the take a look at calls
  featureToggle('feature-new-product-list').
• Replaces the whole conditional expression with the ensuing (i.e., {
identify: 'Product' }), eradicating the toggle logic and leaving simplified code
  behind.

This instance demonstrates how simple it’s to create a helpful
transformation and apply it to a big codebase, considerably lowering
handbook effort.

You’ll want to write down extra take a look at instances to deal with variations like
if-else statements, logical expressions (e.g.,
!featureToggle('feature-new-product-list')), and so forth to make the
codemod sturdy in real-world eventualities.

As soon as the codemod is prepared, you’ll be able to check it out on a goal codebase,
such because the one you are engaged on. jscodeshift gives a command-line
device that you should use to use the codemod and report the outcomes.

$ jscodeshift -t transform-name src/

After validating the outcomes, test that every one purposeful exams nonetheless
go and that nothing breaks—even when you’re introducing a breaking change.
As soon as glad, you’ll be able to commit the adjustments and lift a pull request as
a part of your regular workflow.

Codemods Enhance Code High quality and Maintainability

Codemods aren’t simply helpful for managing breaking API adjustments—they will
considerably enhance code high quality and maintainability. As codebases
evolve, they typically accumulate technical debt, together with outdated function
toggles, deprecated strategies, or tightly coupled parts. Manually
refactoring these areas may be time-consuming and error-prone.

By automating refactoring duties, codemods assist maintain your codebase clear
and freed from legacy patterns. Often making use of codemods permits you to
implement new coding requirements, take away unused code, and modernize your
codebase with out having to manually modify each file.

Refactoring an Avatar Part

Now, let’s have a look at a extra advanced instance. Suppose you’re working with
a design system that features an Avatar part tightly coupled with a
Tooltip. Every time a person passes a identify prop into the Avatar, it
mechanically wraps the avatar with a tooltip.

Determine 3: A avatar part with a tooltip

Right here’s the present Avatar implementation:

import { Tooltip } from "@design-system/tooltip";

const Avatar = ({ identify, picture }: AvatarProps) => {
  if (identify) {
    return (
      
        
      
    );
  }

  return ;
};

The aim is to decouple the Tooltip from the Avatar part,
giving builders extra flexibility. Builders ought to have the ability to determine
whether or not to wrap the Avatar in a Tooltip. Within the refactored model,
Avatar will merely render the picture, and customers can apply a Tooltip
manually if wanted.

Right here’s the refactored model of Avatar:

const Avatar = ({ picture }: AvatarProps) => {
  return ;
};

Now, customers can manually wrap the Avatar with a Tooltip as
wanted:

import { Tooltip } from "@design-system/tooltip";
import { Avatar } from "@design-system/avatar";

const UserProfile = () => {
  return (
    
      
    
  );
};

The problem arises when there are a whole lot of Avatar usages unfold
throughout the codebase. Manually refactoring every occasion can be extremely
inefficient, so we will use a codemod to automate this course of.

Utilizing instruments like AST Explorer, we will
examine the part and see which nodes signify the Avatar utilization
we’re focusing on. An Avatar part with each identify and picture props
is parsed into an summary syntax tree as proven under:

Determine 4: AST of the Avatar part utilization

Writing the Codemod

Let’s break down the transformation into smaller duties:

• Discover Avatar utilization within the part tree.
• Test if the identify prop is current.
• If not, do nothing.
• If current:
• Create a Tooltip node.
• Add the identify to the Tooltip.
• Take away the identify from Avatar.
• Add Avatar as a baby of the Tooltip.
• Change the unique Avatar node with the brand new Tooltip.

To start, we’ll discover all cases of Avatar (I’ll omit a number of the
exams, however you must write comparability exams first).

defineInlineTest(
    { default: rework, parser: "tsx" },
    {},
    `
    
    `,
    `
    
      
    
    `,
    "wrap avatar with tooltip when identify is offered"
  );

Much like the featureToggle instance, we will use root.discover with
search standards to find all Avatar nodes:

root
  .discover(j.JSXElement, {
    openingElement: { identify: { identify: "Avatar" } },
  })
  .forEach((path) => {
    // now we will deal with every Avatar occasion
  });

Subsequent, we test if the identify prop is current:

root
  .discover(j.JSXElement, {
    openingElement: { identify: { identify: "Avatar" } },
  })
  .forEach((path) => {
    const avatarNode = path.node;

    const nameAttr = avatarNode.openingElement.attributes.discover(
      (attr) => attr.identify.identify === "identify"
    );

    if (nameAttr) {
      const tooltipElement = createTooltipElement(
        nameAttr.worth.worth,
        avatarNode
      );
      j(path).replaceWith(tooltipElement);
    }
  });

For the createTooltipElement operate, we use the
jscodeshift API to create a brand new JSX node, with the identify
prop utilized to the Tooltip and the Avatar
part as a baby. Lastly, we name replaceWith to
change the present path.

Right here’s a preview of the way it appears in
Hypermod, the place the codemod is written on
the left. The highest half on the precise is the unique code, and the underside
half is the remodeled outcome:

Determine 5: Run checks inside hypermod earlier than apply it to your codebase

This codemod searches for all cases of Avatar. If a
identify prop is discovered, it removes the identify prop
from Avatar, wraps the Avatar inside a
Tooltip, and passes the identify prop to the
Tooltip.

By now, I hope it’s clear that codemods are extremely helpful and
that the workflow is intuitive, particularly for large-scale adjustments the place
handbook updates can be an enormous burden. Nonetheless, that is not the entire
image. Within the subsequent part, I’ll make clear a number of the challenges
and the way we will handle these less-than-ideal elements.

Leveraging Supply Graphs and Take a look at-Pushed Codemods

To deal with these complexities, codemods must be used alongside different
methods. As an illustration, a couple of years in the past, I participated in a design
system parts rewrite challenge at Atlassian. We addressed this challenge by
first looking the supply graph, which contained nearly all of inside
part utilization. This allowed us to know how parts have been used,
whether or not they have been imported underneath totally different names, or whether or not sure
public props have been ceaselessly used. After this search part, we wrote our
take a look at instances upfront, guaranteeing we coated nearly all of use instances, and
then developed the codemod.

In conditions the place we could not confidently automate the improve, we
inserted feedback or “TODOs” on the name websites. This allowed the
builders operating the script to deal with particular instances manually. Normally,
there have been solely a handful of such cases, so this strategy nonetheless proved
useful for upgrading variations.

Using Present Code Standardization Instruments

As you’ll be able to see, there are many edge instances to deal with, particularly in
codebases past your management—corresponding to exterior dependencies. This
complexity signifies that utilizing codemods requires cautious supervision and a
overview of the outcomes.

Nonetheless, in case your codebase has standardization instruments in place, corresponding to a
linter that enforces a selected coding type, you’ll be able to leverage these
instruments to cut back edge instances. By imposing a constant construction, instruments
like linters assist slender down the variations in code, making the
transformation simpler and minimizing surprising points.

As an illustration, you possibly can use linting guidelines to limit sure patterns,
corresponding to avoiding nested conditional (ternary) operators or imposing named
exports over default exports. These guidelines assist streamline the codebase,
making codemods extra predictable and efficient.

Moreover, breaking down advanced transformations into smaller, extra
manageable ones permits you to sort out particular person points extra exactly. As
we’ll quickly see, composing smaller codemods could make dealing with advanced
adjustments extra possible.

Codemod Composition

Let’s revisit the function toggle removing instance mentioned earlier. Within the code snippet
we’ve got a toggle known as feature-convert-new have to be eliminated:

import { featureToggle } from "./utils/featureToggle";

const convertOld = (enter: string) => {
  return enter.toLowerCase();
};

const convertNew = (enter: string) => {
  return enter.toUpperCase();
};

const outcome = featureToggle("feature-convert-new")
  ? convertNew("Good day, world")
  : convertOld("Good day, world");

console.log(outcome);

The codemod for take away a given toggle works effective, and after operating the codemod,
we would like the supply to appear like this:

const convertNew = (enter: string) => {
  return enter.toUpperCase();
};

const outcome = convertNew("Good day, world");

console.log(outcome);

Nonetheless, past eradicating the function toggle logic, there are further duties to
deal with:

• Take away the unused convertOld operate.
• Clear up the unused featureToggle import.

In fact, you possibly can write one large codemod to deal with all the things in a
single go and take a look at it collectively. Nonetheless, a extra maintainable strategy is
to deal with codemod logic like product code: break the duty into smaller,
impartial items—identical to how you’d usually refactor manufacturing
code.

Breaking It Down

We are able to break the large transformation down into smaller codemods and
compose them. The benefit of this strategy is that every transformation
may be examined individually, overlaying totally different instances with out interference.
Furthermore, it permits you to reuse and compose them for various
functions.

As an illustration, you may break it down like this:

• A change to take away a selected function toggle.
• One other transformation to wash up unused imports.
• A change to take away unused operate declarations.

By composing these, you’ll be able to create a pipeline of transformations:

import { removeFeatureToggle } from "./remove-feature-toggle";
import { removeUnusedImport } from "./remove-unused-import";
import { removeUnusedFunction } from "./remove-unused-function";

import { createTransformer } from "./utils";

const removeFeatureConvertNew = removeFeatureToggle("feature-convert-new");

const rework = createTransformer([
  removeFeatureConvertNew,
  removeUnusedImport,
  removeUnusedFunction,
]);

export default rework;

On this pipeline, the transformations work as follows:

1. Take away the feature-convert-new toggle.
2. Clear up the unused import assertion.
3. Take away the convertOld operate because it’s not used.

Determine 6: Compose transforms into a brand new rework

You can even extract further codemods as wanted, combining them in
numerous orders relying on the specified end result.

Determine 7: Put totally different transforms right into a pipepline to kind one other rework

The createTransformer Operate

The implementation of the createTransformer operate is comparatively
easy. It acts as a higher-order operate that takes a listing of
smaller rework features, iterates via the listing to use them to
the basis AST, and eventually converts the modified AST again into supply
code.

import { API, Assortment, FileInfo, JSCodeshift, Choices } from "jscodeshift";

kind TransformFunction = { (j: JSCodeshift, root: Assortment): void };

const createTransformer =
  (transforms: TransformFunction[]) =>
  (fileInfo: FileInfo, api: API, choices: Choices) => {
    const j = api.jscodeshift;
    const root = j(fileInfo.supply);

    transforms.forEach((rework) => rework(j, root));
    return root.toSource(choices.printOptions || { quote: "single" });
  };

export { createTransformer };

For instance, you possibly can have a rework operate that inlines
expressions assigning the function toggle name to a variable, so in later
transforms you don’t have to fret about these instances anymore:

const shouldEnableNewFeature = featureToggle('feature-convert-new');

if (!shouldEnableNewFeature && someOtherLogic) {
  //...
}

Turns into this:

if (!featureToggle('feature-convert-new') && someOtherLogic) {
  //...
}

Over time, you may construct up a set of reusable, smaller
transforms, which may vastly ease the method of dealing with difficult edge
instances. This strategy proved extremely efficient in our work refining design
system parts. As soon as we transformed one package deal—such because the button
part—we had a couple of reusable transforms outlined, like including feedback
firstly of features, eradicating deprecated props, or creating aliases
when a package deal is already imported above.

Every of those smaller transforms may be examined and used independently
or mixed for extra advanced transformations, which hurries up subsequent
conversions considerably. Because of this, our refinement work turned extra
environment friendly, and these generic codemods at the moment are relevant to different inside
and even exterior React codebases.

Since every rework is comparatively standalone, you’ll be able to fine-tune them
with out affecting different transforms or the extra advanced, composed ones. For
occasion, you may re-implement a rework to enhance efficiency—like
lowering the variety of node-finding rounds—and with complete take a look at
protection, you are able to do this confidently and safely.